Skip to content

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Feb 12, 2025

This allows configuring the type from within the ingest reroute processor. Similar to dataset and namespace, the type defaults to the value extracted from the index name. This means that documents sent to logs-mysql.access.default will have a default value of logs for the type.

Resolves #121553

This allows configuring the `type` from within the ingest `reroute` processor. Similar to `dataset`
and `namespace`, the type defaults to the value extracted from the index name. This means that
documents sent to `logs-mysql.access.default` will have a default value of `logs` for the type.

Resolves elastic#121553
@dakrone dakrone added >enhancement :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v9.0.0 v8.19.0 labels Feb 12, 2025
@dakrone dakrone requested a review from felixbarny February 12, 2025 16:26
Copy link
Contributor

Documentation preview:

Copy link
Contributor

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@elasticsearchmachine
Copy link
Collaborator

Hi @dakrone, I've created a changelog YAML for you.

Copy link
Contributor

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@dakrone
Copy link
Member Author

dakrone commented Feb 12, 2025

Assuming no other blocking things, I can remove the docs part of this and do it in a separate PR after the docs migration.

@dakrone dakrone marked this pull request as ready for review February 12, 2025 21:19
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Feb 12, 2025
Copy link
Contributor

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

Copy link
Contributor

@lukewhiting lukewhiting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Clean with decent tests. Just the ASCIIDocs warning outstanding but looks like you have that in hand.

Copy link
Contributor

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@dakrone dakrone added the auto-backport Automatically create backport pull requests when merged label Feb 18, 2025
@dakrone dakrone merged commit 2ae80c7 into elastic:main Feb 18, 2025
16 of 17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.0
8.x

dakrone added a commit to dakrone/elasticsearch that referenced this pull request Feb 18, 2025
* Allow setting the `type` in the reroute processor

This allows configuring the `type` from within the ingest `reroute` processor. Similar to `dataset`
and `namespace`, the type defaults to the value extracted from the index name. This means that
documents sent to `logs-mysql.access.default` will have a default value of `logs` for the type.

Resolves elastic#121553

* Update docs/changelog/122409.yaml
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Feb 18, 2025
* Allow setting the `type` in the reroute processor

This allows configuring the `type` from within the ingest `reroute` processor. Similar to `dataset`
and `namespace`, the type defaults to the value extracted from the index name. This means that
documents sent to `logs-mysql.access.default` will have a default value of `logs` for the type.

Resolves elastic#121553

* Update docs/changelog/122409.yaml
elasticsearchmachine pushed a commit that referenced this pull request Feb 18, 2025
* Allow setting the `type` in the reroute processor

This allows configuring the `type` from within the ingest `reroute` processor. Similar to `dataset`
and `namespace`, the type defaults to the value extracted from the index name. This means that
documents sent to `logs-mysql.access.default` will have a default value of `logs` for the type.

Resolves #121553

* Update docs/changelog/122409.yaml
elasticsearchmachine pushed a commit that referenced this pull request Feb 18, 2025
* Allow setting the `type` in the reroute processor

This allows configuring the `type` from within the ingest `reroute` processor. Similar to `dataset`
and `namespace`, the type defaults to the value extracted from the index name. This means that
documents sent to `logs-mysql.access.default` will have a default value of `logs` for the type.

Resolves #121553

* Update docs/changelog/122409.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ingest Node] Add type with default data_stream.type to reroute processor

4 participants