Skip to content

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 12, 2025

If we hit the circuit breaker exception before fetching pages, we fail to notify the listener.

Closes #122271

@dnhatn dnhatn force-pushed the exchange-source-breaking branch from 8d001ae to 18eb40a Compare February 12, 2025 17:01
@dnhatn dnhatn changed the title Fix leak listener in exchange service Fix listener leak in exchange service Feb 12, 2025
@dnhatn dnhatn requested review from nik9000 and smalyshev February 12, 2025 23:59
@elasticsearchmachine
Copy link
Collaborator

Hi @dnhatn, I've created a changelog YAML for you.

@dnhatn dnhatn marked this pull request as ready for review February 13, 2025 00:00
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @dnhatn, I've updated the changelog YAML for you.

@dnhatn dnhatn added the auto-backport Automatically create backport pull requests when merged label Feb 13, 2025
@dnhatn dnhatn merged commit 8e2322c into elastic:main Feb 13, 2025
16 of 17 checks passed
@dnhatn dnhatn deleted the exchange-source-breaking branch February 13, 2025 01:58
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 13, 2025
If we hit the circuit breaker exception before fetching pages, 
we fail to notify the listener.

Closes elastic#122271
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 13, 2025
If we hit the circuit breaker exception before fetching pages, 
we fail to notify the listener.

Closes elastic#122271
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 13, 2025
If we hit the circuit breaker exception before fetching pages, 
we fail to notify the listener.

Closes elastic#122271
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 13, 2025

Status Branch Result
8.18
8.x
9.0

elasticsearchmachine pushed a commit that referenced this pull request Feb 13, 2025
If we hit the circuit breaker exception before fetching pages, 
we fail to notify the listener.

Closes #122271
elasticsearchmachine pushed a commit that referenced this pull request Feb 13, 2025
If we hit the circuit breaker exception before fetching pages, 
we fail to notify the listener.

Closes #122271
elasticsearchmachine pushed a commit that referenced this pull request Feb 13, 2025
If we hit the circuit breaker exception before fetching pages, 
we fail to notify the listener.

Closes #122271
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 13, 2025
If we hit the circuit breaker exception before fetching pages,
we fail to notify the listener.

Closes elastic#122271
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 13, 2025
If we hit the circuit breaker exception before fetching pages,
we fail to notify the listener.

Closes elastic#122271
elasticsearchmachine pushed a commit that referenced this pull request Feb 13, 2025
If we hit the circuit breaker exception before fetching pages,
we fail to notify the listener.

Closes #122271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.17.3 v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] EnrichIT testSumDurationByArtist failing

3 participants