Remove completion listener from ExchangeSourceHandler #122446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
the
auto-backport
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
smalyshev
approved these changes
Feb 13, 2025
|
Thanks @smalyshev |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 13, 2025
With elastic#117410, each remote sink now has its own listener, and the main query won't finish until all remote sink listeners have completed. As a result, we no longer need to wait for the exchange source to finish. This change removes the completion listener to simplify the exchange service. The completion listener could previously return prematurely while remote sinks were still being registered. Closes elastic#122408
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 13, 2025
With elastic#117410, each remote sink now has its own listener, and the main query won't finish until all remote sink listeners have completed. As a result, we no longer need to wait for the exchange source to finish. This change removes the completion listener to simplify the exchange service. The completion listener could previously return prematurely while remote sinks were still being registered. Closes elastic#122408
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 13, 2025
With elastic#117410, each remote sink now has its own listener, and the main query won't finish until all remote sink listeners have completed. As a result, we no longer need to wait for the exchange source to finish. This change removes the completion listener to simplify the exchange service. The completion listener could previously return prematurely while remote sinks were still being registered. Closes elastic#122408
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 13, 2025
) With #117410, each remote sink now has its own listener, and the main query won't finish until all remote sink listeners have completed. As a result, we no longer need to wait for the exchange source to finish. This change removes the completion listener to simplify the exchange service. The completion listener could previously return prematurely while remote sinks were still being registered. Closes #122408
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 13, 2025
) With #117410, each remote sink now has its own listener, and the main query won't finish until all remote sink listeners have completed. As a result, we no longer need to wait for the exchange source to finish. This change removes the completion listener to simplify the exchange service. The completion listener could previously return prematurely while remote sinks were still being registered. Closes #122408
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 13, 2025
) With #117410, each remote sink now has its own listener, and the main query won't finish until all remote sink listeners have completed. As a result, we no longer need to wait for the exchange source to finish. This change removes the completion listener to simplify the exchange service. The completion listener could previously return prematurely while remote sinks were still being registered. Closes #122408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #117410, each remote sink now has its own listener, and the main query won't finish until all remote sink listeners have completed. As a result, we no longer need to wait for the exchange source to finish.
This change removes the completion listener to simplify the exchange service. The completion listener could previously return prematurely while remote sinks were still being registered.
Closes #122408