[Entitlements] Instrument nio path #122507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosche
added
:Core/Infra/Core
rjernst
reviewed
Feb 13, 2025
...src/main/java/org/elasticsearch/entitlement/runtime/api/ElasticsearchEntitlementChecker.java
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/entitlement/runtime/api/ElasticsearchEntitlementChecker.java
Outdated
Show resolved
Hide resolved
rjernst
approved these changes
Feb 14, 2025
| class PathActions { | ||
|
|
||
| @EntitlementTest(expectedAccess = PLUGINS) | ||
| static void checkToRealPath() throws IOException { |
Member
There was a problem hiding this comment.
nit: we haven't been consistent, but in other files we've named this as classMethodName, no "check"
Contributor
Author
There was a problem hiding this comment.
We're fairly inconsistent, see NioFileSystemActions
Contributor
There was a problem hiding this comment.
I've auto-generated most of the names in my tests, so I don't mess them up, like this. Not pretty, especially when suffixes are needed for overloads. 🤷
This reverts commit 8cc0a71.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
Author
|
I've updated to PR to check links using |
rjernst
reviewed
Feb 14, 2025
...src/main/java/org/elasticsearch/entitlement/runtime/api/ElasticsearchEntitlementChecker.java
Outdated
Show resolved
Hide resolved
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Feb 17, 2025
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Feb 17, 2025
(cherry picked from commit 7fd1add) # Conflicts: # libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/api/ElasticsearchEntitlementChecker.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Feb 17, 2025
(cherry picked from commit 7fd1add) # Conflicts: # libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/api/ElasticsearchEntitlementChecker.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrument nio
PathtoRealPathandregister.Some other methods may throw
SecurityExceptions, though they are not relevant in our context:Path.of/Paths.get, same asFileSystemProvider#getPath... no need to protect#toAbsolutePath, we grant read access to sys properties (user.dir) anyways, no need to protect in that case#toUri, same as#toAbsolutePathRelates to ES-10794