Fix handling of object arrays FallbackSyntheticSourceBlockLoader #122528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkts
force-pushed
the
synthetic_source_block_loader_unsigned_long
branch
from
10f9191 to
91a32f2
Compare
lkts
force-pushed
the
synthetic_source_block_loader_unsigned_long
branch
from
91a32f2 to
1847aca
Compare
lkts
added
>non-issue
auto-backport
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation does not handle object arrays appearing inside fallback synthetic source when field is stored as part of a parent object. This PR adds testing code that exposes the issue and fixes it.