-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Instrument methods on File that require read permissions #122544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit adds instrumentation for File methods that require read permissions. see elastic#122109 for the write side
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'd test with test-entitlements to be sure we are not missing a policy somewhere
) This commit adds instrumentation for File methods that require read permissions. see elastic#122109 for the write side
💔 Backport failed
You can use sqren/backport to manually backport by running |
) This commit adds instrumentation for File methods that require read permissions. see elastic#122109 for the write side
) This commit adds instrumentation for File methods that require read permissions. see elastic#122109 for the write side (cherry picked from commit bf1cbb0) # Conflicts: # x-pack/plugin/security/src/main/plugin-metadata/entitlement-policy.yaml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…122862) This commit adds instrumentation for File methods that require read permissions. see #122109 for the write side (cherry picked from commit bf1cbb0) # Conflicts: # x-pack/plugin/security/src/main/plugin-metadata/entitlement-policy.yaml Co-authored-by: Ryan Ernst <[email protected]>
This commit adds instrumentation for File methods that require read permissions.
see #122109 for the write side