Skip to content

Conversation

@rjernst
Copy link
Member

@rjernst rjernst commented Feb 13, 2025

This commit adds instrumentation for File methods that require read permissions.

see #122109 for the write side

This commit adds instrumentation for File methods that require read permissions.

see elastic#122109 for the write side
@rjernst rjernst added :Core/Infra/Core Core issues without another label >refactoring auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 labels Feb 13, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst rjernst requested a review from a team February 14, 2025 15:32
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd test with test-entitlements to be sure we are not missing a policy somewhere

@rjernst rjernst enabled auto-merge (squash) February 17, 2025 14:16
@rjernst rjernst merged commit bf1cbb0 into elastic:main Feb 17, 2025
21 of 22 checks passed
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Feb 17, 2025
)

This commit adds instrumentation for File methods that require read permissions.

see elastic#122109 for the write side
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.18 Commit could not be cherrypicked due to conflicts
8.x
9.0

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 122544

rjernst added a commit to rjernst/elasticsearch that referenced this pull request Feb 17, 2025
)

This commit adds instrumentation for File methods that require read permissions.

see elastic#122109 for the write side
elasticsearchmachine pushed a commit that referenced this pull request Feb 17, 2025
…122786)

This commit adds instrumentation for File methods that require read permissions.

see #122109 for the write side
elasticsearchmachine pushed a commit that referenced this pull request Feb 17, 2025
…122787)

This commit adds instrumentation for File methods that require read permissions.

see #122109 for the write side
mosche pushed a commit to mosche/elasticsearch that referenced this pull request Feb 18, 2025
)

This commit adds instrumentation for File methods that require read permissions.

see elastic#122109 for the write side

(cherry picked from commit bf1cbb0)

# Conflicts:
#	x-pack/plugin/security/src/main/plugin-metadata/entitlement-policy.yaml
@mosche
Copy link
Contributor

mosche commented Feb 18, 2025

💚 All backports created successfully

Status Branch Result
8.18

Questions ?

Please refer to the Backport tool documentation

@mosche
Copy link
Contributor

mosche commented Feb 18, 2025

I created the missing backport for this @rjernst , it was failing tests for my backport #122851

elasticsearchmachine pushed a commit that referenced this pull request Feb 18, 2025
…122862)

This commit adds instrumentation for File methods that require read permissions.

see #122109 for the write side

(cherry picked from commit bf1cbb0)

# Conflicts:
#	x-pack/plugin/security/src/main/plugin-metadata/entitlement-policy.yaml

Co-authored-by: Ryan Ernst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending :Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants