[Test] Fix assertion for number of message chunks #122571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the position of the split and the size of the extra chunk, the test may send out one more chunk than the assertion expects. This PR ensures the assertoin is more accurate to count for this scenario. Resolves: elastic#122349
ywangd
added
>test
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination
Member
Author
|
@elasticmachine update branch |
ywangd
added
auto-merge-without-approval
Collaborator
💚 Backport successful
|
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Feb 17, 2025
Depending on the position of the split and the size of the extra chunk, the test may send out one more chunk than the assertion expects. This PR ensures the assertoin is more accurate to count for this scenario. Resolves: elastic#122349
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
Depending on the position of the split and the size of the extra chunk, the test may send out one more chunk than the assertion expects. This PR ensures the assertoin is more accurate to count for this scenario. Resolves: #122349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the position of the split and the size of the extra chunk, the test may send out one more chunk than the assertion expects. This PR ensures the assertoin is more accurate to count for this scenario.
Resolves: #122349