[8.x] Rewire 8.19 backport constants to avoid conflicts with 8.18 backport constants #122580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
:Core/Infra/Core
This was referenced Feb 14, 2025
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Feb 14, 2025
| public static final TransportVersion COHERE_BIT_EMBEDDING_TYPE_SUPPORT_ADDED_BACKPORT_8_X = def(8_840_0_01); | ||
| public static final TransportVersion REMOVE_ALL_APPLICABLE_SELECTOR_BACKPORT_8_X = def(8_840_0_02); | ||
| public static final TransportVersion ELASTICSEARCH_8_19 = def(8_841_0_00); | ||
| public static final TransportVersion COHERE_BIT_EMBEDDING_TYPE_SUPPORT_ADDED_BACKPORT_8_X = def(8_841_0_01); |
Member
There was a problem hiding this comment.
Separately (it can be in a followup) we should rename these constants. Using _X suffix isn't descriptive enough, ever, because whatever branch it is backported to will become a release branch. So this should always be the exact minor version that is backported to.
ldematte
added
the
auto-merge-without-approval
ldematte
removed
the
auto-merge-without-approval
…9-transport-versions
…:ldematte/elasticsearch into backport/8.x/fix-8-19-transport-versions
This was referenced Feb 17, 2025
This was referenced Feb 17, 2025
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Feb 18, 2025
All those issues have been opened by test automation, before some missing transport versions was fixed (see elastic#122580). Closes elastic#122688 Closes elastic#122689 Closes elastic#122690 Closes elastic#122691 Closes elastic#122694 Closes elastic#122695 Closes elastic#122696 Closes elastic#122697 Closes elastic#122698 Closes elastic#122700 Closes elastic#122701 Closes elastic#122702 Closes elastic#122703 Closes elastic#122704 Closes elastic#122705
tlrx
added a commit
that referenced
this pull request
Feb 18, 2025
All those issues have been opened by test automation, before some missing transport versions was fixed (see #122580). Closes #122688 Closes #122689 Closes #122690 Closes #122691 Closes #122694 Closes #122695 Closes #122696 Closes #122697 Closes #122698 Closes #122700 Closes #122701 Closes #122702 Closes #122703 Closes #122704 Closes #122705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#122578 and #122582 ready to propagate changes to newer barnches