Skip to content

[Entitlements] Add logsDir to entitlement bootstrap parameters #122605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 17, 2025
Merged

[Entitlements] Add logsDir to entitlement bootstrap parameters #122605

merged 7 commits into from
Feb 17, 2025

Conversation

ldematte
Copy link
Contributor

While testing #122591, I realized we need to grand read/write permission to the logs dir to server.

This PR adds the logsDir to the bootstrap parameters, and uses it in the server policy.

@ldematte ldematte added >non-issue :Core/Infra/Core Core issues without another label auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 labels Feb 14, 2025
@ldematte ldematte requested a review from a team as a code owner February 14, 2025 14:27
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

rjernst
rjernst approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldematte ldematte requested review from a team, mosche and prdoyle February 14, 2025 15:21
@ldematte
Copy link
Contributor Author

Thanks @rjernst
This one will need to wait for #122607 too before it can get merged

@rjernst rjernst self-assigned this Feb 14, 2025
@ldematte ldematte added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Feb 14, 2025
@elasticsearchmachine elasticsearchmachine merged commit 191f801 into elastic:main Feb 17, 2025
17 checks passed
@ldematte ldematte deleted the entitlements/logs-dir-bootstrap branch February 17, 2025 07:42
ldematte added a commit to ldematte/elasticsearch that referenced this pull request Feb 17, 2025
@ldematte
[Entitlements] Add logsDir to entitlement bootstrap parameters (elast…
37b6769 
…ic#122605)

While testing elastic#122591, I
realized we need to grand read/write permission to the logs dir to
server.

This PR adds the `logsDir` to the bootstrap parameters, and uses it in
the `server` policy.
@ldematte ldematte mentioned this pull request Feb 17, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 8.x Commit could not be cherrypicked due to conflicts
✅ 9.0

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 122605

ldematte added a commit to ldematte/elasticsearch that referenced this pull request Feb 17, 2025
@ldematte
[Entitlements] Add logsDir to entitlement bootstrap parameters (elast…
68da6ec 
…ic#122605)

While testing elastic#122591, I
realized we need to grand read/write permission to the logs dir to
server.

This PR adds the `logsDir` to the bootstrap parameters, and uses it in
the `server` policy.
@ldematte ldematte mentioned this pull request Feb 17, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Feb 17, 2025
@ldematte
[Entitlements] Add logsDir to entitlement bootstrap parameters (#122605…
59d8912 
…) (#122725)

While testing #122591, I
realized we need to grand read/write permission to the logs dir to
server.

This PR adds the `logsDir` to the bootstrap parameters, and uses it in
the `server` policy.
elasticsearchmachine pushed a commit that referenced this pull request Feb 17, 2025
@ldematte
[Entitlements] Add logsDir to entitlement bootstrap parameters (#122605…
d70be83 
…) (#122726)

While testing #122591, I
realized we need to grand read/write permission to the logs dir to
server.

This PR adds the `logsDir` to the bootstrap parameters, and uses it in
the `server` policy.
@ldematte ldematte mentioned this pull request Feb 17, 2025
Merged
ldematte added a commit to ldematte/elasticsearch that referenced this pull request Feb 17, 2025
@ldematte
[Entitlements] Add logsDir to entitlement bootstrap parameters (elast…
d8aab71 
…ic#122605) (elastic#122726)

While testing elastic#122591, I
realized we need to grand read/write permission to the logs dir to
server.

This PR adds the `logsDir` to the bootstrap parameters, and uses it in
the `server` policy.
elasticsearchmachine pushed a commit that referenced this pull request Feb 17, 2025
@ldematte
[Entitlements] Add logsDir to entitlement bootstrap parameters (#122605…
d210e5e 
…) (#122726) (#122738)

While testing #122591, I
realized we need to grand read/write permission to the logs dir to
server.

This PR adds the `logsDir` to the bootstrap parameters, and uses it in
the `server` policy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjernst rjernst rjernst approved these changes

@prdoyle prdoyle Awaiting requested review from prdoyle

@mosche mosche Awaiting requested review from mosche

Assignees

@rjernst rjernst

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ldematte @elasticsearchmachine @rjernst