Fix listener usage in remote clusters #122629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
dnhatn
added
the
auto-backport
idegtiarenko
approved these changes
Feb 14, 2025
smalyshev
reviewed
Feb 14, 2025
| return ActionListener.runAfter(delegate.delegateResponse((inner, e) -> { | ||
| taskManager.cancelTaskAndDescendants(groupTask, reason, true, ActionListener.running(() -> { | ||
| EsqlCCSUtils.skipUnavailableListener(delegate, executionInfo, clusterAlias, EsqlExecutionInfo.Cluster.Status.PARTIAL) | ||
| EsqlCCSUtils.skipUnavailableListener(inner, executionInfo, clusterAlias, EsqlExecutionInfo.Cluster.Status.PARTIAL) |
Contributor
There was a problem hiding this comment.
Looking at the code, it seems like inner and delegate in this case are the same thing, am I wrong?
Member
Author
There was a problem hiding this comment.
Yes, it should, but it's more idiomatic to use the inner listener.
Member
Author
|
@idegtiarenko @smalyshev Thanks for reviews. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 14, 2025
We should notify the listener provided in delegateResponse/delegateFailure, not the original listener.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should notify the listener provided in delegateResponse/delegateFailure, not the original listener.