Use FallbackSyntheticSourceBlockLoader for unsigned_long and scaled_float fields #122637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkts
added
>enhancement
auto-backport
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @lkts, I've created a changelog YAML for you. |
lkts
commented
Feb 14, 2025
| // but block loaders operate with encoded signed 64 bit values | ||
| // because this is the format doc_values use. | ||
| // So we need to perform this conversion. | ||
| return unsignedToSortableSignedLong(parseUnsignedLong(nullValueFormatted)); |
Contributor
Author
There was a problem hiding this comment.
This is actually a bug fix in existing stored source implementation. I think it's okay to fix it inline here since unsigned_long is in tech preview according to our docs.
Contributor
Author
|
I may need to change tests here depending on #122586 landing. |
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.