Invoke TestCluster#assertAfterTest before closing the cluster #122639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
changed the title
albertzaharovits
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
approved these changes
Feb 14, 2025
Contributor
prdoyle
left a comment
prdoyle
left a comment
There was a problem hiding this comment.
Hard to believe this was deliberate.
prdoyle
added
the
auto-backport
albertzaharovits
added
auto-merge-without-approval
elasticsearchmachine
added
the
serverless-linked
Contributor
Author
|
@elasticsearchmachine run Elasticsearch Serverless Checks |
This was referenced Feb 16, 2025
Collaborator
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Feb 16, 2025
…c#122639) In test-scoped internal ITs the `cluster().assertAfterTest()` method was invoked *after* the cluster nodes were closed. Consequently, the assertions that iterated over the internal nodes (and asserted some state on nodes after the test) were all effectively noops. This PR reverses that order, so that after-test assertions are effective again.
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Feb 16, 2025
…c#122639) In test-scoped internal ITs the `cluster().assertAfterTest()` method was invoked *after* the cluster nodes were closed. Consequently, the assertions that iterated over the internal nodes (and asserted some state on nodes after the test) were all effectively noops. This PR reverses that order, so that after-test assertions are effective again.
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Feb 16, 2025
…c#122639) In test-scoped internal ITs the `cluster().assertAfterTest()` method was invoked *after* the cluster nodes were closed. Consequently, the assertions that iterated over the internal nodes (and asserted some state on nodes after the test) were all effectively noops. This PR reverses that order, so that after-test assertions are effective again.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 16, 2025
… (#122710) In test-scoped internal ITs the `cluster().assertAfterTest()` method was invoked *after* the cluster nodes were closed. Consequently, the assertions that iterated over the internal nodes (and asserted some state on nodes after the test) were all effectively noops. This PR reverses that order, so that after-test assertions are effective again.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 16, 2025
… (#122709) In test-scoped internal ITs the `cluster().assertAfterTest()` method was invoked *after* the cluster nodes were closed. Consequently, the assertions that iterated over the internal nodes (and asserted some state on nodes after the test) were all effectively noops. This PR reverses that order, so that after-test assertions are effective again.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 16, 2025
… (#122711) In test-scoped internal ITs the `cluster().assertAfterTest()` method was invoked *after* the cluster nodes were closed. Consequently, the assertions that iterated over the internal nodes (and asserted some state on nodes after the test) were all effectively noops. This PR reverses that order, so that after-test assertions are effective again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In test-scoped internal ITs the
cluster().assertAfterTest()method was invoked after the cluster nodes were closed. Consequently, the assertions that iterated over the internal nodes (and asserted some state on nodes after the test) were all noops (again, just in the case of test-scoped internal ITs)!This PR reverses that order, so that after test assertions are effective again.
NB: This PR technically changes the order for external clusters too, but those are deprecated now and not used in a test-scoped way, from what I can tell.