Skip to content

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Feb 14, 2025

Disable jackson's field name canonicalization to speed up parsing. We don't use == to test for string equality from field names so we don't need it. It can save memory for sure, but out field names usually don't live very long.

Disable jackson's field name canonicalization to speed up parsing. We
don't use `==` to test for string equality from field names so we don't
*need* it. It can save memory for sure, but out field names usually
don't live very long.
@nik9000 nik9000 added >non-issue :Core/Infra/Core Core issues without another label v9.1.0 labels Feb 14, 2025
@nik9000 nik9000 requested a review from a team as a code owner February 14, 2025 19:48
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 14, 2025
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000
Copy link
Member Author

nik9000 commented Feb 14, 2025

The test failure is real:

REPRODUCE WITH: ./gradlew ":qa:smoke-test-http:javaRestTest" --tests "org.elasticsearch.http.BulkRestIT.testBulkInvalidIndexNameString" -Dtests.seed=169C07E9E01DAD45 -Dtests.locale=ar-SA -Dtests.timezone=America/Danmarkshavn -Druntime.java=23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants