Skip to content

Conversation

@mhl-b
Copy link
Contributor

@mhl-b mhl-b commented Feb 14, 2025

Fixes #122650

JDK 24 added a new exception on truncated file. throw new IOException("Premature EOF"); openjdk/jdk@b6ffb44

Reproduction:

./gradlew ":modules:repository-gcs:test" --tests "org.elasticsearch.repositories.gcs.GoogleCloudStorageBlobContainerRetriesTests.testReadBlobWithPrematureConnectionClose" -Dtests.seed=13999E774122226F -Dtests.jvm.argline="-Des.entitlements.enabled=false" -Dtests.locale=tk -Dtests.timezone=Etc/GMT-11 -Druntime.java=24

Exception:

java.lang.AssertionError: 
Expected: (a string containing "premature end of chunk coded message body: closing chunk expected" or a string containing "premature end of content-length delimited message body" or a string containing "connection closed prematurely" or a string containing "the target server failed to respond")
     but: was "premature eof"

@mhl-b mhl-b added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Coordination Meta label for Distributed Coordination team v9.1.0 labels Feb 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@mhl-b mhl-b requested review from pxsalehi and ywangd February 14, 2025 23:10
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FWIW, we did the same thing for JDK23 #113609

@mhl-b mhl-b merged commit 8b4f159 into elastic:main Feb 17, 2025
17 checks passed
mosche pushed a commit to mosche/elasticsearch that referenced this pull request Feb 27, 2025
mosche pushed a commit to mosche/elasticsearch that referenced this pull request Feb 27, 2025
@mosche
Copy link
Contributor

mosche commented Feb 27, 2025

💚 All backports created successfully

Status Branch Result
8.x
9.0
8.18

Questions ?

Please refer to the Backport tool documentation

mosche pushed a commit to mosche/elasticsearch that referenced this pull request Feb 27, 2025
elasticsearchmachine pushed a commit that referenced this pull request Feb 27, 2025
(cherry picked from commit 8b4f159)

Co-authored-by: Mikhail Berezovskiy <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Feb 27, 2025
(cherry picked from commit 8b4f159)

Co-authored-by: Mikhail Berezovskiy <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Feb 27, 2025
(cherry picked from commit 8b4f159)

Co-authored-by: Mikhail Berezovskiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] GoogleCloudStorageBlobContainerRetriesTests testReadBlobWithPrematureConnectionClose failing

4 participants