Fix policy manager/parser absolute path checks #122736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for absolute/relative that won't work with mixed windows/linux policies
ldematte
added
>test
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
…licy-parser-paths-windows
rjernst
reviewed
Feb 17, 2025
...rc/main/java/org/elasticsearch/entitlement/runtime/policy/entitlements/FilesEntitlement.java
Show resolved
Hide resolved
ldematte
added
auto-merge-without-approval
…licy-parser-paths-windows
….com:ldematte/elasticsearch into entitlements/fix-policy-parser-paths-windows
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 18, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 18, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 18, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes policy manager/parser tests to rely on real files; this would solve the related CI failures already.
But we need to remove assert for absolute/relative paths too, as that won't work with mixed windows/linux/mac policies like we already have on server (e.g. /proc/meminfo)
closes #122662
closes #122663
closes #122664
closes #122665
closes #122666
closes #122775
closes #122776
closes #122777
closes #122778
closes #122779