Skip to content

ESQL: Ensure non-zero row size in EstimatesRowSize #122762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 4, 2025
Merged

ESQL: Ensure non-zero row size in EstimatesRowSize #122762

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b8edd48
Remove assertion
kanoshiou Feb 17, 2025
a8c070c
Update changelog
kanoshiou Feb 17, 2025
f584b7d
Merge branch 'main' into remove-estimated-row-size-assertion
kanoshiou Mar 3, 2025
bef38ef
Review comments
kanoshiou Mar 3, 2025
1c9edbd
Merge branch 'main' into remove-estimated-row-size-assertion
nik9000 Mar 3, 2025
765e7cd
TopN estimate row size
kanoshiou Mar 4, 2025
23f7e11
Aggregate estimate row size
kanoshiou Mar 4, 2025
8751378
Merge branch 'main' into remove-estimated-row-size-assertion
kanoshiou Mar 4, 2025
afc5652
Use `max` function
kanoshiou Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/changelog/122762.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
pr: 122762
summary: "ESQL: Remove estimated row size assertion"
area: ES|QL
type: bug
issues:
- 121535
1 change: 0 additions & 1 deletion ...plugin/esql/src/main/java/org/elasticsearch/xpack/esql/planner/LocalExecutionPlanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,6 @@ private PhysicalOperation planExchangeSource(ExchangeSourceExec exchangeSource,

private PhysicalOperation planTopN(TopNExec topNExec, LocalExecutionPlannerContext context) {
final Integer rowSize = topNExec.estimatedRowSize();
assert rowSize != null && rowSize > 0 : "estimated row size [" + rowSize + "] wasn't set";
PhysicalOperation source = plan(topNExec.child(), context);

ElementType[] elementTypes = new ElementType[source.layout.numberOfChannels()];
Expand Down