Use apache client in GCS repository #122809
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktindall
commented
Feb 18, 2025
| final PoolingHttpClientConnectionManager connectionManager = new PoolingHttpClientConnectionManager(); | ||
| connectionManager.setMaxTotal(maxOpenConnections); | ||
| connectionManager.setDefaultMaxPerRoute(maxOpenConnections); | ||
| return connectionManager; |
There was a problem hiding this comment.
There is no setting to purge idle connections from the pool (see "Connection Eviction Policy" here).
We would have to schedule a task to do that.
There was a problem hiding this comment.
org.apache.http.impl.client.HttpClientBuilder#evictExpiredConnections doesn't work if we want to share a thread pool.
Please note this method has no effect if the instance of HttpClient is configuted[sic] to use a shared connection manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC to use the Apache HTTP client implementation in the GCS repository client (considered as an approach to work around some limitations of the GCS interceptor)
Clients share a connection pool but nothing else. We could perhaps have the GCS clients share Apache HTTP clients once we start making client-per-purpose.
This change seems to struggle with the tests where the server doesn't respond. Apache seems to throw an exception under those circumstances which doesn't get retried. It also seems to have issues with stale connections in the pool when the server doesn't respond.
I'm not sure whether this is
I tried setting
connectionReuseStrategytoNoConnectionReuseStrategyto see if it was an issue with the pooling, which seemed to improve things, but the errors persisted. I suspect the problem is not due to the pooling.But I'm going to do what I can with the existing client and leave this for later.