[Entitlements] Instrumentation of NIO file channels #122816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mosche
reviewed
Feb 18, 2025
| } | ||
| } | ||
|
|
||
| static class DummyFileChannel extends FileChannel { |
There was a problem hiding this comment.
Wondering, that's a lot of code to just test close and it's not directly obvious what this is used for. Maybe add a comment or is it simpler in the end to create a channel via the entitled plugin?
There was a problem hiding this comment.
Wait, makes sense, I misread the test... we reject subclassing 👍
ldematte
added
:Core/Infra/Entitlements
💔 Backport failed
You can use sqren/backport to manually backport by running |
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 19, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 19, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 20, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 20, 2025
…122591) (#122986) * [Entitlements] Add check functions for NIO Files (#122591) * [Entitlements] Instrumentation of NIO file channels (#122816) * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 20, 2025
and elastic#122591) (elastic#122986) * [Entitlements] Add check functions for NIO Files (elastic#122591) * [Entitlements] Instrumentation of NIO file channels (elastic#122816) * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to ES-10795
Some minor overlap with #122591 and #122406, I will solve both during merges