Unmute FrozenSearchableSnapshotsIntegTests#testCreateAndRestorePartialSearchableSnapshot
#122831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alSearchableSnapshot` The underlying failure `java.lang.AssertionError: Searchable snapshot directory does not support the operation [createOutput` was fixed in elastic#122006. The automation bot was too aggressive in re-opening this issue. Resolve elastic#122693
arteam
added
>test
elasticsearchmachine
added
Team:Distributed Indexing
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
Member
|
I think both failures are legit and require investigation, since they both contain #122006. Looking at the logs I can see: So I suspect the fix in #122006 is not complete and should also consider CLOSED state along with STOPPED. |
Contributor
Author
|
@tlrx Let me add an extra state check 👍 |
tlrx
approved these changes
Feb 18, 2025
...shots/src/main/java/org/elasticsearch/xpack/searchablesnapshots/cache/full/CacheService.java
Outdated
Show resolved
Hide resolved
…arch/xpack/searchablesnapshots/cache/full/CacheService.java Co-authored-by: Tanguy Leroux <[email protected]>
arteam
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying failure
java.lang.AssertionError: Searchable snapshot directory does not support the operation [createOutputwas fixed in #122006.The automation bot was too aggressive in re-opening this issue.
Resolve #122693