Miscellaneous java.base file entitlements #122906
Conversation
prdoyle
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
added
:Core/Infra/Entitlements
| var instrumentationMethod = checkMethods.get(key); | ||
| if (instrumentationMethod != null) { | ||
| // System.out.println("Will instrument method " + key); | ||
| logger.debug("Will instrument {}", key); |
There was a problem hiding this comment.
Can you please split this out? We've talked about it across several PRs, let's do it, but as distinct commits.
There was a problem hiding this comment.
I thought the controversy was using exceptions to get a stack trace.
There was a problem hiding this comment.
There's no controversy, I just think adding debug logging to instrumentation is unrelated to adding miscellaneous file entitlements?
| } | ||
|
|
||
| @EntitlementTest(expectedAccess = PLUGINS) | ||
| static void createScannerFile() throws FileNotFoundException { |
There was a problem hiding this comment.
Aren't all of the rest of the methods in this file also in java.base? I don't understand the distinction as to why they belong in a separate files vs in this one.
There was a problem hiding this comment.
Oh I didn't check. I just moved over the ones that were on the spreadsheet tab.
What would you like to do? Merge them together?
There was a problem hiding this comment.
Maybe split them based on some explainable attributes? I don't feel strongly, but it seems like having a test file that implies java.base classes should be tested in it, yet other test files contain java.base classes, will cause confusion.
There was a problem hiding this comment.
I'm not sure I can explain why these ended up in their own spreadsheet tab. Maybe I'll just merge them into FileCheckActions.
| } | ||
|
|
||
| @EntitlementTest(expectedAccess = PLUGINS) | ||
| static void zipFile_1() throws IOException { |
There was a problem hiding this comment.
In other tests we've named these logically based on the parameters. Could we do that here too?
* java.base entitlements * SuppressForbidden, and add a missing test * Revert logging back to commented-out printlns * Merge FileCheckActions and rename for overloads * Remove stray logger * Remove more traces of logging change * Remove more traces of logging
* java.base entitlements * SuppressForbidden, and add a missing test * Revert logging back to commented-out printlns * Merge FileCheckActions and rename for overloads * Remove stray logger * Remove more traces of logging change * Remove more traces of logging
* java.base entitlements * SuppressForbidden, and add a missing test * Revert logging back to commented-out printlns * Merge FileCheckActions and rename for overloads * Remove stray logger * Remove more traces of logging change * Remove more traces of logging
* java.base entitlements * SuppressForbidden, and add a missing test * Revert logging back to commented-out printlns * Merge FileCheckActions and rename for overloads * Remove stray logger * Remove more traces of logging change * Remove more traces of logging
* java.base entitlements * SuppressForbidden, and add a missing test * Revert logging back to commented-out printlns * Merge FileCheckActions and rename for overloads * Remove stray logger * Remove more traces of logging change * Remove more traces of logging
3 participants
See ES-10905.