[Entitlements] Log message for troubleshooting if not entitled #122948
Conversation
elasticsearchmachine
added
needs:triage
mosche
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mosche
added
the
auto-merge-without-approval
| private static void notEntitled(String message, Class<?> callerClass) { | ||
| // don't log self tests in EntitlementBootstrap | ||
| if (EntitlementBootstrap.class.equals(callerClass) == false) { | ||
| logger.warn(message); |
There was a problem hiding this comment.
If you construct the not entitled exception first then the exception can be logged, along with the stack trace.
There was a problem hiding this comment.
I thought about doing it, but decided against it as we'd be logging the exception twice most of the time. I often find that more confusing / disturbing than being helpful in rare cases. On the other hand, obviously, those warnings are a lot more noticeable if there's a stacktrace attached.
I don't have a strong preference, happy to follow the crowed here.
There was a problem hiding this comment.
I don't feel strongly in this case. The message is likely to have enough info to determine the remedy already.
There was a problem hiding this comment.
Same, not a strong preference. OK to leave it as-is -- like you said, this is mainly for when we have code that catches Throwable or similar.
mosche
removed
the
auto-merge-without-approval
mosche
added
the
auto-merge-without-approval
…ic#122948) Log message for troubleshooting if not entitled.
…ic#122948) Log message for troubleshooting if not entitled.
…ic#122948) Log message for troubleshooting if not entitled.
…) (#122961) Log message for troubleshooting if not entitled.
…) (#122963) Log message for troubleshooting if not entitled.
…) (#122962) Log message for troubleshooting if not entitled.
5 participants
Log message for troubleshooting if not entitled.