Simplify logic/mutability in TopHitsAggregator.getLeafCollector #122952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't be creating new collectors while also swtiching out the `leafCollectors` structure. The safety of this is somewhat tricky to reason about and also it's needlessly slow too to keep indirectly accessing the mutable field. Also, lets extract the logic creating the leaf conllectors to a hopefully cold path and save needless lookups from the top docs collectors in it.
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
original-brownbear
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be creating new collectors while also swtiching out the
leafCollectorsstructure. The safety of this is somewhat tricky to reason about and also it's needlessly slow too to keep indirectly accessing the mutable field. Also, lets extract the logic creating the leaf collectors to a hopefully cold path and save needless lookups from the top docs collectors in it.Lastly, remove deprecated/noop
falseconcurrency flags.