Reinstate BYTE_SIZE_VALUE_ALWAYS_USES_BYTES #122964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
reviewed
Feb 21, 2025
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
Looks fine but let's be consistent with the style of other transport version checks.
server/src/main/java/org/elasticsearch/common/unit/ByteSizeValue.java
Outdated
Show resolved
Hide resolved
rjernst
approved these changes
Feb 21, 2025
| ); | ||
| for (var tv : List.of(TransportVersion.current(), BYTE_SIZE_VALUE_ALWAYS_USES_BYTES, BYTE_SIZE_VALUE_ALWAYS_USES_BYTES_90)) { | ||
| for (var desiredUnit : ByteSizeUnit.values()) { | ||
| if (desiredUnit == ByteSizeUnit.BYTES) { |
Contributor
Author
There was a problem hiding this comment.
You can't have a fraction of a byte, but you can have a fraction of any other unit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows fractional units, like
1.1KB, to be preserved across the transport protocol instead of turning into1126B.This should be backported to
9.0but the transport versions there are out of sync withmainso I'll hold off until I can coordinate with them.See ES-10585.