[Gradle] Fix and simplify disabling assertions in test tasks #123038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
>non-issue
:Delivery/Build
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
added
the
auto-merge-without-approval
breskeby
force-pushed
the
test-assertions
branch
from
2b7cda9 to
a0eef90
Compare
breskeby
force-pushed
the
test-assertions
branch
from
400bc7a to
845c762
Compare
breskeby
force-pushed
the
test-assertions
branch
from
40a1533 to
2008ce3
Compare
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 4, 2025
…#123038) Fixes misleading assertion configuration for test tasks from the command line. We support the following command line args: 1. `-Dtests.jvm.argline=-disableassertions` 2. `-Dtests.jvm.argline=-da` 3. `-Dtests.asserts=false`
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 4, 2025
…#123038) Fixes misleading assertion configuration for test tasks from the command line. We support the following command line args: 1. `-Dtests.jvm.argline=-disableassertions` 2. `-Dtests.jvm.argline=-da` 3. `-Dtests.asserts=false`
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 4, 2025
…#123038) Fixes misleading assertion configuration for test tasks from the command line. We support the following command line args: 1. `-Dtests.jvm.argline=-disableassertions` 2. `-Dtests.jvm.argline=-da` 3. `-Dtests.asserts=false`
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 4, 2025
…#123038) Fixes misleading assertion configuration for test tasks from the command line. We support the following command line args: 1. `-Dtests.jvm.argline=-disableassertions` 2. `-Dtests.jvm.argline=-da` 3. `-Dtests.asserts=false`
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 4, 2025
…#123038) Fixes misleading assertion configuration for test tasks from the command line. We support the following command line args: 1. `-Dtests.jvm.argline=-disableassertions` 2. `-Dtests.jvm.argline=-da` 3. `-Dtests.asserts=false`
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 4, 2025
#123971) Fixes misleading assertion configuration for test tasks from the command line. We support the following command line args: 1. `-Dtests.jvm.argline=-disableassertions` 2. `-Dtests.jvm.argline=-da` 3. `-Dtests.asserts=false`
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 4, 2025
#123970) Fixes misleading assertion configuration for test tasks from the command line. We support the following command line args: 1. `-Dtests.jvm.argline=-disableassertions` 2. `-Dtests.jvm.argline=-da` 3. `-Dtests.asserts=false`
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 4, 2025
#123969) Fixes misleading assertion configuration for test tasks from the command line. We support the following command line args: 1. `-Dtests.jvm.argline=-disableassertions` 2. `-Dtests.jvm.argline=-da` 3. `-Dtests.asserts=false`
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 4, 2025
#123972) Fixes misleading assertion configuration for test tasks from the command line. We support the following command line args: 1. `-Dtests.jvm.argline=-disableassertions` 2. `-Dtests.jvm.argline=-da` 3. `-Dtests.asserts=false`
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 4, 2025
#123968) Fixes misleading assertion configuration for test tasks from the command line. We support the following command line args: 1. `-Dtests.jvm.argline=-disableassertions` 2. `-Dtests.jvm.argline=-da` 3. `-Dtests.asserts=false`
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
…#123038) Fixes misleading assertion configuration for test tasks from the command line. We support the following command line args: 1. `-Dtests.jvm.argline=-disableassertions` 2. `-Dtests.jvm.argline=-da` 3. `-Dtests.asserts=false`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes misleading assertion configuration for test tasks from the command line.
We support the following command line args:
-Dtests.jvm.argline=-disableassertions-Dtests.jvm.argline=-da-Dtests.asserts=false