-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Adding endpoint creation validation to ElasticsearchInternalService #123044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dan-rubinstein
merged 12 commits into
elastic:main
from
dan-rubinstein:es-internal-service-validation
Apr 8, 2025
Merged
Adding endpoint creation validation to ElasticsearchInternalService #123044
dan-rubinstein
merged 12 commits into
elastic:main
from
dan-rubinstein:es-internal-service-validation
Apr 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @dan-rubinstein, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
dan-rubinstein
commented
Mar 13, 2025
...icsearch/xpack/inference/services/validation/ElasticsearchInternalServiceModelValidator.java
Outdated
Show resolved
Hide resolved
Contributor
jonathan-buttner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just left a few questions
...ain/java/org/elasticsearch/xpack/inference/mock/TestStreamingCompletionServiceExtension.java
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/inference/action/TransportPutInferenceModelAction.java
Show resolved
Hide resolved
...icsearch/xpack/inference/services/validation/ElasticsearchInternalServiceModelValidator.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/elasticsearch/xpack/inference/services/validation/ModelValidatorBuilder.java
Show resolved
Hide resolved
...g/elasticsearch/xpack/inference/services/elasticsearch/BaseElasticsearchInternalService.java
Outdated
Show resolved
Hide resolved
…l deployment starting to model validator
jonathan-buttner
approved these changes
Apr 7, 2025
Member
Author
|
@elasticmachine merge upstream |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
dan-rubinstein
added a commit
to dan-rubinstein/elasticsearch
that referenced
this pull request
Apr 8, 2025
…lastic#123044) * Adding validation to ElasticsearchInternalService * Update docs/changelog/123044.yaml * [CI] Auto commit changes from spotless * Removing checkModelConfig * Fixing IT * [CI] Auto commit changes from spotless * Remove DeepSeek checkModelConfig and fix tests * Cleaning up comments, updating validation input type, and moving model deployment starting to model validator --------- Co-authored-by: elasticsearchmachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
dan-rubinstein
added a commit
that referenced
this pull request
Apr 8, 2025
…123044) (#126472) * Adding validation to ElasticsearchInternalService * Update docs/changelog/123044.yaml * [CI] Auto commit changes from spotless * Removing checkModelConfig * Fixing IT * [CI] Auto commit changes from spotless * Remove DeepSeek checkModelConfig and fix tests * Cleaning up comments, updating validation input type, and moving model deployment starting to model validator --------- Co-authored-by: elasticsearchmachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
backport pending
>enhancement
:ml
Machine learning
Team:ML
Meta label for the ML team
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds endpoint creation validation to all task types for ElasticsearchInternalService. As part of this change we can refactor all of our other services to remove
checkModelConfigas they all callModelValidatorBuilder.buildModelValidator(...).validate(...). This can now be pulled out of the inference service and called directly in the TransportPutInferenceModelAction. This reduces the amount of duplicated code across inference service and test files. Part of this change also updates the model validators to take in a timeout value to ensure that the validation process ends if a users exceeds their requested timeout time.TLDR of changes made in this PR to accomplish the above:
checkModelConfigfrom all servicesTesting