Add lifecycle setting to destination index after adding to data stream #123071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkertimmins
added
>non-issue
:Data Management/Data streams
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
masseyke
reviewed
Feb 20, 2025
.../main/java/org/elasticsearch/xpack/migrate/task/ReindexDataStreamPersistentTaskExecutor.java
Show resolved
Hide resolved
masseyke
reviewed
Feb 20, 2025
.../main/java/org/elasticsearch/xpack/migrate/action/ReindexDataStreamIndexTransportAction.java
Show resolved
Hide resolved
masseyke
approved these changes
Feb 20, 2025
Member
masseyke
left a comment
masseyke
left a comment
There was a problem hiding this comment.
Other than my comment about adding a couple of comments (we won't remember this at all a year from now), LGTM.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
parkertimmins
added a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Feb 21, 2025
elastic#123071) When reindexing a data stream, remove the lifecycle name setting when creating the destination index, so that ILM does not process it. Add the setting back after adding the destination index to the data stream, at which point ILM can safely process it.
parkertimmins
added a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Feb 21, 2025
elastic#123071) When reindexing a data stream, remove the lifecycle name setting when creating the destination index, so that ILM does not process it. Add the setting back after adding the destination index to the data stream, at which point ILM can safely process it. (cherry picked from commit f044d97) # Conflicts: # x-pack/plugin/migrate/src/internalClusterTest/java/org/elasticsearch/xpack/migrate/action/ReindexDatastreamIndexTransportActionIT.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
parkertimmins
added a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Feb 21, 2025
elastic#123071) When reindexing a data stream, remove the lifecycle name setting when creating the destination index, so that ILM does not process it. Add the setting back after adding the destination index to the data stream, at which point ILM can safely process it. (cherry picked from commit f044d97) # Conflicts: # x-pack/plugin/migrate/src/internalClusterTest/java/org/elasticsearch/xpack/migrate/action/ReindexDatastreamIndexTransportActionIT.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 21, 2025
#123071) (#123159) When reindexing a data stream, remove the lifecycle name setting when creating the destination index, so that ILM does not process it. Add the setting back after adding the destination index to the data stream, at which point ILM can safely process it. (cherry picked from commit f044d97) # Conflicts: # x-pack/plugin/migrate/src/internalClusterTest/java/org/elasticsearch/xpack/migrate/action/ReindexDatastreamIndexTransportActionIT.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 21, 2025
#123071) (#123158) When reindexing a data stream, remove the lifecycle name setting when creating the destination index, so that ILM does not process it. Add the setting back after adding the destination index to the data stream, at which point ILM can safely process it. (cherry picked from commit f044d97) # Conflicts: # x-pack/plugin/migrate/src/internalClusterTest/java/org/elasticsearch/xpack/migrate/action/ReindexDatastreamIndexTransportActionIT.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 6, 2025
… stream (#123071) (#123151) * Add lifecycle setting to destination index after adding to data stream (#123071) When reindexing a data stream, remove the lifecycle name setting when creating the destination index, so that ILM does not process it. Add the setting back after adding the destination index to the data stream, at which point ILM can safely process it. * [CI] Auto commit changes from spotless * timeout now in request in 9.0 * another silly compilation error * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a lifecycle name is added to an index, ILM will immediately attempt to process it. When reindexing indices, if the destination index has a lifecycle name before it added to the data stream, this will cause ILM to fail. We should filter out the lifecycle name from the setting copied from the source index to the destination index, and only add it back to the destination index after it has been added to the data stream.