Misc non-java.base file entitlements #123078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
>non-issue
auto-backport
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
reviewed
Feb 21, 2025
| dependencies { | ||
| compileOnly project(':server') | ||
| compileOnly project(':libs:logging') | ||
| compileOnly project(":libs:entitlement") |
Contributor
There was a problem hiding this comment.
Not blocking, but I wonder why you had to add this?
Contributor
Author
There was a problem hiding this comment.
Oh I don't need it anymore. I can remove it.
In an earlier draft, I had one of the tests catch NotEntitledException to make sure that the right part of the test was throwing. That turned out not to be necessary in the end.
ldematte
approved these changes
Feb 21, 2025
Contributor
ldematte
left a comment
ldematte
left a comment
There was a problem hiding this comment.
LGTM, just a couple of questions
| requires org.elasticsearch.server; | ||
| requires org.elasticsearch.base; | ||
| requires org.elasticsearch.logging; | ||
| requires org.elasticsearch.entitlement; |
Contributor
There was a problem hiding this comment.
Again not blocking, but I wonder why you had to add this?
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Feb 21, 2025
* Misc non-java.base file entitlements * Remove unnecessary dependency
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Feb 21, 2025
* Misc non-java.base file entitlements * Remove unnecessary dependency
Contributor
Author
|
8.x backport is #123154. |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 21, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 21, 2025
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Feb 21, 2025
* Misc non-java.base file entitlements * Remove unnecessary dependency
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining miscellaneous file entitlements for classes outside
java.base.See ES-10906.