Skip to content

Conversation

@kanoshiou
Copy link
Contributor

Fix #123126

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.1.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Feb 21, 2025
@astefan astefan requested a review from lkts February 21, 2025 13:17
@lkts lkts self-assigned this Feb 21, 2025
@lkts
Copy link
Contributor

lkts commented Feb 21, 2025

Thanks @kanoshiou! These tests are repeating ScaledFloatFieldBlockLoaderTests, they are not removed because we are in the middle of migrating to the new test structure. However given they are our of sync already i think we can just remove them now. I'll make that change.

@lkts lkts added the >test Issues or PRs that are addressing/adding tests label Feb 21, 2025
@lkts lkts force-pushed the fix-failed-test-123126 branch from 82b985d to 2fbf52a Compare February 21, 2025 18:16
@lkts
Copy link
Contributor

lkts commented Feb 21, 2025

buildkite test this please

@lkts lkts added :Analytics/ES|QL AKA ESQL :StorageEngine/Mapping The storage related side of mappings labels Feb 21, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:StorageEngine and removed needs:triage Requires assignment of a team area label labels Feb 21, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@lkts lkts merged commit 7326928 into elastic:main Feb 21, 2025
19 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 123144

@lkts
Copy link
Contributor

lkts commented Feb 21, 2025

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Feb 21, 2025
(cherry picked from commit 7326928)

# Conflicts:
#	muted-tests.yml

Co-authored-by: kanoshiou <[email protected]>
@kanoshiou
Copy link
Contributor Author

Thank you @lkts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged backport pending external-contributor Pull request authored by a developer outside the Elasticsearch team :StorageEngine/Mapping The storage related side of mappings Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:StorageEngine >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0

Projects

None yet

3 participants