Skip to content

Fix failed ScaledFloatFieldMapperTests #123144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lkts merged 4 commits into from
Feb 21, 2025
Merged

Fix failed ScaledFloatFieldMapperTests #123144

lkts merged 4 commits into from
Feb 21, 2025

Conversation

@kanoshiou
Copy link
Contributor

@kanoshiou kanoshiou commented Feb 21, 2025

Fix #123126

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.1.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Feb 21, 2025
@astefan astefan requested a review from lkts February 21, 2025 13:17
@lkts lkts self-assigned this Feb 21, 2025
@lkts
Copy link
Contributor

lkts commented Feb 21, 2025

Thanks @kanoshiou! These tests are repeating ScaledFloatFieldBlockLoaderTests, they are not removed because we are in the middle of migrating to the new test structure. However given they are our of sync already i think we can just remove them now. I'll make that change.

@lkts lkts added the >test Issues or PRs that are addressing/adding tests label Feb 21, 2025
@lkts lkts force-pushed the fix-failed-test-123126 branch from 82b985d to 2fbf52a Compare February 21, 2025 18:16
@lkts
Copy link
Contributor

lkts commented Feb 21, 2025

buildkite test this please

@lkts lkts added :Analytics/ES|QL AKA ESQL :StorageEngine/Mapping The storage related side of mappings labels Feb 21, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:StorageEngine and removed needs:triage Requires assignment of a team area label labels Feb 21, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 21, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 21, 2025

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@lkts lkts added auto-backport Automatically create backport pull requests when merged v8.19.0 labels Feb 21, 2025
This was linked to issues Feb 21, 2025
[CI] ScaledFloatFieldMapperTests testBlockLoaderFromRowStrideReaderWithSyntheticSource failing #123145
Closed
[CI] ScaledFloatFieldMapperTests testBlockLoaderFromColumnReaderWithSyntheticSource failing #123149
Closed
@lkts lkts merged commit 7326928 into elastic:main Feb 21, 2025
19 checks passed
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 21, 2025

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 123144

@lkts lkts mentioned this pull request Feb 21, 2025
Merged
@lkts
Copy link
Contributor

lkts commented Feb 21, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Feb 21, 2025
@lkts @kanoshiou
Fix failed ScaledFloatFieldMapperTests (#123144) (#123184)
284b621 
(cherry picked from commit 7326928)

# Conflicts:
#	muted-tests.yml

Co-authored-by: kanoshiou <[email protected]>
@kanoshiou
Copy link
Contributor Author

kanoshiou commented Feb 21, 2025

Thank you @lkts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lkts lkts lkts approved these changes

Assignees

@lkts lkts

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged backport pending external-contributor Pull request authored by a developer outside the Elasticsearch team :StorageEngine/Mapping The storage related side of mappings Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:StorageEngine >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

3 participants

@kanoshiou @lkts @elasticsearchmachine