Skip to content

[8.x] apm-data: use representative count as event.success_count if available (#119995) #123165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubvs merged 1 commit into from
Feb 21, 2025
Merged

[8.x] apm-data: use representative count as event.success_count if available (#119995) #123165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/119995.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 119995
summary: "apm-data: Use representative count as event.success_count if available"
area: Ingest Node
type: bug
issues: []
11 changes: 7 additions & 4 deletions x-pack/plugin/apm-data/src/main/resources/ingest-pipelines/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,16 @@ processors:
field: ["event.duration"]
ignore_failure: true
ignore_missing: true
- set:
if: ctx.event?.outcome == 'success'
field: event.success_count
value: 1
- set:
if: ctx.event?.outcome == 'failure'
field: event.success_count
value: 0
- set:
if: ctx.event?.outcome == 'success'
field: event.success_count
value: 1
- script:
if: ctx.event?.outcome == 'success' && ctx[ctx.processor?.event]?.representative_count != null
source: ctx.event.success_count = ctx[ctx.processor?.event]?.representative_count;
- pipeline:
name: apm@pipeline
42 changes: 37 additions & 5 deletions x-pack/plugin/apm-data/src/yamlRestTest/resources/rest-api-spec/test/20_traces_ingest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,35 @@ setup:
- '{"@timestamp": "2017-06-22", "event": {"outcome": "unknown"}}'

- create: {}
- '{"@timestamp": "2017-06-22", "event": {"outcome": "success"}}'
- '{
"@timestamp": "2017-06-22",
"processor": {"event": "transaction"},
"event": {"outcome": "success"},
"transaction": {"representative_count": 2}
}'

- create: {}
- '{
"@timestamp": "2017-06-22",
"processor": {"event": "span"},
"event": {"outcome": "success"},
"span": {"representative_count": 3}
}'

- create: {}
- '{
"@timestamp": "2017-06-22",
"processor": {"event": "span"},
"event": {"outcome": "success"},
"span": {"representative_count": null}
}'

- create: {}
- '{
"@timestamp": "2017-06-22",
"processor": {"event": "transaction"},
"event": {"outcome": "success"}
}'

- create: {}
- '{"@timestamp": "2017-06-22", "event": {"outcome": "failure"}}'
Expand All @@ -92,11 +120,15 @@ setup:
index: traces-apm-testing
body:
fields: ["event.success_count"]
- length: { hits.hits: 4 }
- length: { hits.hits: 7 }
- match: { hits.hits.0.fields: null }
- match: { hits.hits.1.fields: null }
- match: { hits.hits.2.fields: {"event.success_count": [1]} }
- match: { hits.hits.3.fields: {"event.success_count": [0]} }
- match: { hits.hits.2.fields: {"event.success_count": [2]} }
- match: { hits.hits.3.fields: {"event.success_count": [3]} }
- match: { hits.hits.4.fields: {"event.success_count": [1]} }
- match: { hits.hits.5.fields: {"event.success_count": [1]} }
- match: { hits.hits.6.fields: {"event.success_count": [0]} }

---
"Test traces-apm-* setting event.ingested via ingest pipeline":
- requires:
Expand All @@ -123,4 +155,4 @@ setup:
fields: ["event.ingested"]
- length: { hits.hits: 2 }
- is_after: { hits.hits.1.fields.event\.ingested.0: "2017-06-22T00:00:00.000Z" }