Pass transient extra data on new commits #123175
Conversation
kingherc
added
>non-issue
:Distributed Indexing/Engine
Relates ES-10718
kingherc
force-pushed
the
non-issue/ES-10718-pass-translog-number
branch
from
181b2e7 to
6c653fc
Compare
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
…pass-translog-number
server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
A smaller suggestion.
server/src/main/java/org/elasticsearch/index/engine/Engine.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
…pass-translog-number
…pass-translog-number
…pass-translog-number
…pass-translog-number
…pass-translog-number
…pass-translog-number
…pass-translog-number
…pass-translog-number
kingherc
left a comment
kingherc
left a comment
There was a problem hiding this comment.
Incorporated your feedback. Feel free to review again!
server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/engine/Engine.java
Outdated
Show resolved
Hide resolved
| long primaryTerm, | ||
| IndexCommitRef indexCommitRef, | ||
| Set<String> additionalFiles, | ||
| Object enginePreCommitData |
There was a problem hiding this comment.
now that I'm reading this again, I think that the name is misleading? this data was acquired after the commit was created.
There was a problem hiding this comment.
@henningandersen suggested the name, but I see also the slight confusion. I had originally suggested "transient commit data". Would that be better @fcofdez ? I welcome possible naming suggestions!
There was a problem hiding this comment.
(fyi "pre" I think meant "before the commit is exposed". but I see the slight confusion.)
|
Closing in favor of a different approach. |
5 participants
Relates ES-10718