Prune extraneous files entitlements paths to prevent incorrect binary search #123177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>bug
auto-backport
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @jdconrad, I've created a changelog YAML for you. |
rjernst
approved these changes
Feb 21, 2025
| assertThat(tree.canRead(path("foo/bar")), is(true)); | ||
| assertThat(tree.canWrite(path("foo/bar")), is(false)); | ||
| assertThat(tree.canRead(path("foo/baz")), is(true)); | ||
| assertThat(tree.canWrite(path("foo/baz")), is(false)); |
Member
There was a problem hiding this comment.
Can we test a path has read access that is not explicitly entitled? ie that would be hit by the bug
| this.writePaths = pruneSortedPaths(writePaths).toArray(new String[0]); | ||
| } | ||
|
|
||
| public static List<String> pruneSortedPaths(List<String> paths) { |
This was referenced Feb 22, 2025
[8.x] Prune extraneous files entitlements paths to prevent incorrect binary search (#123177)
#123206
Merged
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Feb 22, 2025
Collaborator
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Feb 22, 2025
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Feb 22, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 22, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 22, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an incorrect binary search by pruning files entitlements paths at the time of construction.
As an example:
This would previously cause
/foo/bazto see/foo/baras its parent instead of/foo.This change prunes
/foo/barfrom the read list since/foois already available. And nowfoo/bazwill seefooas its parent.