Speedup MultiTermsAggregator #123220
Merged
Speedup MultiTermsAggregator #123220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating (and more importantly eventually resizing) a fresh stream output makes up a large chunk of the runtime of this aggregation. Also, recursively calling an inline consumer makes this logic even more confusing and adds additional overhead as escape analysis will not be able to remove the allocation of the consumer. => just call a method recursively and reuse the output
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
iverase
approved these changes
Feb 24, 2025
Contributor
Author
|
Thanks Ignacio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating (and more importantly eventually resizing) a fresh stream output makes up a large chunk of the runtime of this aggregation. Also, recursively calling an inline consumer makes this logic even more confusing and adds additional overhead as escape analysis will not be able to remove the allocation of the consumer. => just call a method recursively and reuse the output.