Only fork TransportGetAllocationStatsAction if heavy allocation stats are requested #123225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are requested Don't fork unless the heavy stats calculation is requested. Also, this is superior to forking via the transport action as it avoids capturing the clusterstate in the forked task which can become a problem when these tasks take a long time to run.
original-brownbear
added
>non-issue
:Data Management/Stats
elasticsearchmachine
added
v9.1.0
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Contributor
Author
|
superseded by #123246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't fork unless the heavy stats calculation is requested. Also, this is superior to forking via the transport action as it avoids capturing the clusterstate in the forked task which can become a problem when these tasks take a long time to run.