Fix NPE in ReindexDataStreamTransportAction
#123262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the multi-project branch, we're making some changes to persistent tasks and those changes can cause the persistent tasks custom to still be `null`. This resulted in an NPE here, so I'm fixing the check here.
nielsbauman
added
>non-issue
:Data Management/Data streams
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
changed the title
ReindexDataStreamTransportActionReindexDataStreamTransportAction
lukewhiting
approved these changes
Feb 24, 2025
Contributor
lukewhiting
left a comment
lukewhiting
left a comment
There was a problem hiding this comment.
LGTM 👍🏻 Null checks in PersistentTasksCustomMetadata.getTaskWithId(...) look a lot safer
This was referenced Feb 24, 2025
Collaborator
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Feb 24, 2025
In the multi-project branch, we're making some changes to persistent tasks and those changes can cause the persistent tasks custom to still be `null`. This resulted in an NPE here, so I'm fixing the check here.
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Feb 24, 2025
In the multi-project branch, we're making some changes to persistent tasks and those changes can cause the persistent tasks custom to still be `null`. This resulted in an NPE here, so I'm fixing the check here.
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Feb 24, 2025
In the multi-project branch, we're making some changes to persistent tasks and those changes can cause the persistent tasks custom to still be `null`. This resulted in an NPE here, so I'm fixing the check here.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
In the multi-project branch, we're making some changes to persistent tasks and those changes can cause the persistent tasks custom to still be `null`. This resulted in an NPE here, so I'm fixing the check here.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
In the multi-project branch, we're making some changes to persistent tasks and those changes can cause the persistent tasks custom to still be `null`. This resulted in an NPE here, so I'm fixing the check here.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
In the multi-project branch, we're making some changes to persistent tasks and those changes can cause the persistent tasks custom to still be `null`. This resulted in an NPE here, so I'm fixing the check here.
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Feb 27, 2025
There is no guarantee that a project has non-null persistent tasks [0]. Null check is already done in most places. This PR adds it in a few more places. [0] Since health-node is now a cluster-scoped persistent task, it has become more likely for the project-scoped tasks to be null. Relates: elastic#123262
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 27, 2025
There is no guarantee that a project has non-null persistent tasks [0]. Null check is already done in most places. This PR adds it in a few more places. [0] Since health-node is now a cluster-scoped persistent task, it has become more likely for the project-scoped tasks to be null. Relates: #123262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the multi-project branch, we're making some changes to persistent tasks and those changes can cause the persistent tasks custom to still be
null. This resulted in an NPE here, so I'm fixing the check here.