ESQL: Benchmark TO_LOWER and TO_UPPER #123268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a microbenchmark for TO_LOWER and TO_UPPER. They are quite common probably could use some optimizing.
nik9000
added
auto-backport
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Member
Author
|
I haven't a clue why TO_UPPER is slower in the microbenchmark. I swapped the other and ran them and got the same result. |
bpintea
reviewed
Feb 24, 2025
| } | ||
| } | ||
| } | ||
| case "to_lower" -> checkBytes(operation, actual, new BytesRef[] { new BytesRef("foo"), new BytesRef("bar") }); |
Contributor
There was a problem hiding this comment.
Nitty nit: wondering if it make sense extracting the BytesRef[] as it's used both in page generation and the check... though probably not. :)
bpintea
approved these changes
Feb 24, 2025
Collaborator
💚 Backport successful
|
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Feb 24, 2025
This adds a microbenchmark for TO_LOWER and TO_UPPER. They are quite common probably could use some optimizing.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a microbenchmark for TO_LOWER and TO_UPPER. They are quite common probably could use some optimizing.