FileAccessTree fixes for ordering and pruning #123291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
>non-issue
auto-backport
prdoyle
changed the title
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
commented
Feb 24, 2025
| for (int i = 1; i < paths.size(); ++i) { | ||
| String nextPath = paths.get(i); | ||
| if (nextPath.startsWith(currentPath) == false) { | ||
| if (isParent(currentPath, nextPath) == false) { |
prdoyle
commented
Feb 24, 2025
| return path.toAbsolutePath().normalize().toString(); | ||
| String result = path.toAbsolutePath().normalize().toString(); | ||
| while (result.endsWith(FILE_SEPARATOR)) { | ||
| result = result.substring(0, result.length() - FILE_SEPARATOR.length()); |
Contributor
Author
There was a problem hiding this comment.
The fix to strip trailing separators
This was referenced Feb 24, 2025
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Feb 24, 2025
* Custom comparator for paths in FileAccessTree * Strip trailing separators in normalizePath
Collaborator
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Feb 24, 2025
* Custom comparator for paths in FileAccessTree * Strip trailing separators in normalizePath
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.sorting before/normalizePath