Reduce licence checks in LicensedWriteLoadForecaster
#123346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than checking the license (updating the usage map) on every single shard, just do it once at the start of a computation that needs to forecast write loads. Closes elastic#123247
DaveCTurner
added
>bug
:Distributed Indexing/CRUD
elasticsearchmachine
added
the
Team:Distributed Indexing
Collaborator
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
fcofdez
approved these changes
Feb 25, 2025
Contributor
fcofdez
left a comment
fcofdez
left a comment
There was a problem hiding this comment.
LGTM. I expected that calling to that method would be cheap. Thanks for fixing this.
|
|
||
| static { | ||
| try { | ||
| VH_HAS_VALID_LICENCE_FIELD = MethodHandles.lookup() |
Contributor
There was a problem hiding this comment.
why do we need to use a VarHandle here?
Contributor
Author
There was a problem hiding this comment.
We're checking the license state in a hot loop so I didn't want to introduce another layer of indirection on the read path, but I wanted an atomic getAndSet on the write path for the sake of getting the logging right. I'll add a comment.
Contributor
Author
|
The test failures are genuine, this'll need more work. |
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
deleted the
2025/02/25/write-load-forecast-licence-checks
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 25, 2025
Rather than checking the license (updating the usage map) on every single shard, just do it once at the start of a computation that needs to forecast write loads. Closes elastic#123247
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 25, 2025
Rather than checking the license (updating the usage map) on every single shard, just do it once at the start of a computation that needs to forecast write loads. Backport of elastic#123346 to 8.x Closes elastic#123247
Contributor
Author
|
8.x-and-earlier backports in progress in #123369 |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 25, 2025
Rather than checking the license (updating the usage map) on every single shard, just do it once at the start of a computation that needs to forecast write loads. Backport of elastic#123346 to 8.x Closes elastic#123247
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 25, 2025
Rather than checking the license (updating the usage map) on every single shard, just do it once at the start of a computation that needs to forecast write loads. Backport of elastic#123346 to 8.x Closes elastic#123247
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 25, 2025
Rather than checking the license (updating the usage map) on every single shard, just do it once at the start of a computation that needs to forecast write loads. Backport of elastic#123346 to 8.x Closes elastic#123247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than checking the license (updating the usage map) on every
single shard, just do it once at the start of a computation that needs
to forecast write loads.
Closes #123247