[Entitlements] Fix how we suppress logs for self-tests #123361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
auto-backport
elasticsearchmachine
added
v9.1.0
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 25, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 25, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 25, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 25, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 25, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we moved where we perform self tests, skipping logs for self tests can't be done trivially anymore by just not logging for
EntitlementBootstrap.This PR adds a set of muted classes to
BootstrapArgs, and moves the self test should out ofElasticsearchinto a separate class, so we don't mute all ofElasticsearch.