[Test] Add test for AWS SDKv1 swallowing exception at IndexputStream close time #123505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Member
Author
|
Thanks Brendan & Francisco! |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 2, 2025
Reverts the test added in elastic#123505 - this is not behaviour on which we rely any more, and it does not apply with SDKv2 anyway.
DaveCTurner
added a commit
that referenced
this pull request
Apr 2, 2025
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
Reverts the test added in elastic#123505 - this is not behaviour on which we rely any more, and it does not apply with SDKv2 anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a unit test to demonstrate a specific behavior of the AWS SDKv1, which closes the
InputStreamused to upload a blob only after the HTTP request has been sent (this is to accomodate for retries). The SDK then swallows any exception thrown when closing theInputStreamwhich has the effect to hide any potential CorruptIndexException that could have been detected at that time.Relates ES-10931