Add ignore_url for setting based files entitlement #123541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File entitlements which read a setting may actually contain urls. This commit adds an optional `ignore_url` property for the entitlement to skip any values which are urls.
rjernst
added
>refactoring
auto-backport
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mark-vieira
reviewed
Feb 26, 2025
| } | ||
| String path = pathLookup.settingResolver().apply(setting); | ||
| return path == null ? Stream.of() : Stream.of(Path.of(path)); | ||
| return result.map(Path::of); |
Contributor
There was a problem hiding this comment.
In what scenario would it make sense to not use ignore_url in a file entitlement? Wouldn't calling Path.of() explode on such a value if it weren't filtered out? Should this behavior be the default?
Member
Author
There was a problem hiding this comment.
Yes it would explode. But we don't support urls in all settings? These are very specific settings that allow a url to be present. I don't want to add leniency generally to all file settings.
This was referenced Feb 26, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 26, 2025
File entitlements which read a setting may actually contain urls. This commit adds an optional `ignore_url` property for the entitlement to skip any values which are urls.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 26, 2025
File entitlements which read a setting may actually contain urls. This commit adds an optional `ignore_url` property for the entitlement to skip any values which are urls.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 26, 2025
File entitlements which read a setting may actually contain urls. This commit adds an optional `ignore_url` property for the entitlement to skip any values which are urls.
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File entitlements which read a setting may actually contain urls. This commit adds an optional
ignore_urlproperty for the entitlement to skip any values which are urls.