Skip to content

Add missing APM agent entitlements #123575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Add missing APM agent entitlements #123575

merged 1 commit into from
Feb 27, 2025

Conversation

@mosche
Copy link
Contributor

@mosche mosche commented Feb 27, 2025

Add missing APM agent entitlements

@mosche mosche requested a review from a team as a code owner February 27, 2025 08:49
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.1.0 labels Feb 27, 2025
@mosche mosche added >non-issue auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 :Core/Infra/Entitlements Entitlements infrastructure and removed needs:triage Requires assignment of a team area label labels Feb 27, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 27, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 27, 2025

Pinging @elastic/es-core-infra (Team:Core/Infra)

idegtiarenko
idegtiarenko approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@idegtiarenko idegtiarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ldematte
ldematte approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I wonder if this is the only right place to add them, and #123462 is redundant. I'm investigating this today.

@mosche mosche added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Feb 27, 2025
@elasticsearchmachine elasticsearchmachine merged commit 3282697 into elastic:main Feb 27, 2025
17 checks passed
@mosche mosche deleted the entitlements/fix_apm_agent branch February 27, 2025 10:03
mosche added a commit to mosche/elasticsearch that referenced this pull request Feb 27, 2025
@mosche
Add missing APM agent entitlements (elastic#123575)
19edb4c 
Add missing APM agent entitlements
This was referenced Feb 27, 2025
Merged
Merged
mosche added a commit to mosche/elasticsearch that referenced this pull request Feb 27, 2025
@mosche
Add missing APM agent entitlements (elastic#123575)
1fe184b 
Add missing APM agent entitlements
@mosche mosche mentioned this pull request Feb 27, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 27, 2025

💚 Backport successful

Status Branch Result
✅ 8.18
✅ 8.x
✅ 9.0

mosche added a commit to mosche/elasticsearch that referenced this pull request Feb 27, 2025
@mosche
Add missing APM agent entitlements (elastic#123575)
6323b81 
Add missing APM agent entitlements
elasticsearchmachine pushed a commit that referenced this pull request Feb 27, 2025
@mosche
Add missing APM agent entitlements (#123575) (#123581)
610b844 
Add missing APM agent entitlements
elasticsearchmachine pushed a commit that referenced this pull request Feb 27, 2025
@mosche
Add missing APM agent entitlements (#123575) (#123580)
df519bf 
Add missing APM agent entitlements
mosche added a commit that referenced this pull request Feb 27, 2025
@mosche
Add missing APM agent entitlements (#123575) (#123579)
0a47363 
Add missing APM agent entitlements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@idegtiarenko idegtiarenko idegtiarenko approved these changes

@ldematte ldematte ldematte approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Entitlements Entitlements infrastructure >non-issue Team:Core/Infra Meta label for core/infra team v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mosche @elasticsearchmachine @idegtiarenko @ldematte