Add ActionListener.releaseBefore #123591
Merged
Add ActionListener.releaseBefore #123591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new helper function, ActionListener.releaseBefore, which ensures that a resource is released before the listener is notified.
fcofdez
added
>non-issue
:Distributed Indexing/Distributed
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
|
Makes sense, I've wondered about adding this myself a couple of times.
Could we just wrap the releasable as a CheckedRunnable directly rather than
double-wrapping via Runnable?
|
DaveCTurner
approved these changes
Feb 27, 2025
| * Wraps a given listener and returns a new listener which releases the provided {@code releaseBefore} | ||
| * resource before the listener is notified via either {@code #onResponse} or {@code #onFailure}. | ||
| */ | ||
| static <Response> ActionListener<Response> releaseBefore(ActionListener<Response> delegate, Releasable releaseBefore) { |
There was a problem hiding this comment.
It's always irked me that these params are in the opposite order from their executioin. I guess it's consistent with runBefore(). But do contemplate whether you'd prefer this to be more readable the other way round.
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new helper function, ActionListener.releaseBefore,
which ensures that a resource is released before the listener is notified.