[TESTING] check packaging tests for JDK 24 #123598
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosche
force-pushed
the
jdk/packaging_tests
branch
2 times, most recently
from
558914f to
b941b6b
Compare
mosche
force-pushed
the
jdk/packaging_tests
branch
from
b941b6b to
c1e9131
Compare
mosche
commented
Feb 27, 2025
| // check the supported ciphers and log them here to prevent spamming logs on every call | ||
| supportedCiphers(sslContext.getSupportedSSLParameters().getCipherSuites(), sslConfiguration.getCipherSuites(), true); | ||
| // FIXME error log for unsupported ciphers on JDK 24 breaks packaging tests (see ES-10984) | ||
| supportedCiphers(sslContext.getSupportedSSLParameters().getCipherSuites(), sslConfiguration.getCipherSuites(), false); |
Contributor
Author
There was a problem hiding this comment.
@rjernst this is the error logger that breaks the packaging tests. I've tried fixing those tests to be more robust. Imho they shouldn't care about the logger, but didn't get far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.