Skip to content

Conversation

ldematte
Copy link
Contributor

Relates to ES-10031

@ldematte ldematte added >non-issue auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Feb 27, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

- create_class_loader # needed for Painless to generate runtime classes
- files:
- relative_path: ""
- relative_path_setting: "reindex.ssl.certificate"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjernst I have no idea if I'm using this correctly, as this is the first time we use it I think.
Will this work with exclusive access?
Can I use a glob (reindex.ssl.*) instead?
certificate_authorities is a list; will that work with your file settings implementation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work if the setting is a list, we resolve all paths, whether for a single setting, or multiple settings. It should also work with exclusive. Also note the properties are changing per our earlier discussion, see #123649.

But it's curious that we didn't need this before? I guess it would have only worked if it was relative to the config dir.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note the properties are changing per our earlier discussion, see #123649.

Thanks! So reindex.ssl.* should work? I'll try it/look at logs/debug what it resolves to. Or maybe I'll write a test for it.
I'll update this to use the new properties after that is merged.

@ldematte
Copy link
Contributor Author

ldematte commented Jul 7, 2025

Obsolete

@ldematte ldematte closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >non-issue Team:Core/Infra Meta label for core/infra team v8.18.4 v8.19.0 v9.0.4 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants