[Not For Checkin] Warn when checkpoint duration is longer than frequency #123606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prwhelan
added
>non-issue
:ml/Transform
If a user runs with telemetry enabled, a Transform checkpoint shows up in the APM trace as a collection of discrete API calls. Eventually, Transform will open a trace span when it starts a checkpoint and close a trace span when it finishes a checkpoint. This will unify the discrete API calls into a single APM trace so the user can see all API calls made for a given Transform checkpoint. AsyncTwoPhaseIndexer now has event hooks in place to notify when the indexer starts a new job and finished a job. Eventually, Transforms will use this to open/close the trace span.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For spacetime