Remove matched text from chunks #123607
Merged
Remove matched text from chunks #123607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioanatia
reviewed
Feb 27, 2025
...core/src/main/java/org/elasticsearch/xpack/core/inference/results/ChunkedInferenceError.java
Outdated
Show resolved
Hide resolved
...java/org/elasticsearch/xpack/inference/services/azureaistudio/AzureAiStudioServiceTests.java
Show resolved
Hide resolved
|
@elasticmachine update branch |
|
Pinging @elastic/ml-core (Team:ML) |
ioanatia
approved these changes
Feb 27, 2025
Mikep86
added
the
auto-backport
|
On second thought: I'm also fine with merging this, and I'll rebase my PR on top of this. It's a bit of effort, but that reduces the complexity of my PR. |
jan-elastic
reviewed
Mar 5, 2025
| assertThat(chunkedFloatResult.chunks().get(3).matchedText(), startsWith(" passage_input60 ")); | ||
| assertThat(chunkedFloatResult.chunks().get(4).matchedText(), startsWith(" passage_input80 ")); | ||
| assertThat(chunkedFloatResult.chunks().get(5).matchedText(), startsWith(" passage_input100 ")); | ||
| assertThat(chunkedFloatResult.chunks().get(0).offset(), equalTo(new ChunkedInference.TextOffset(0, 309))); |
There was a problem hiding this comment.
I find to verify that these are the correct assertions.
I'd prefer something like:
assertThat(getMatchedText(inputs.get(1), chunkedFloatResult.chunks().get(5).offset()), startsWith(" passage_input100 "));
together with a simple helper function
private static String getMatchedText(String text, ChunkedInference.TextOffset offset) {
return text.substring(offset.start(), offset.end());
}
jan-elastic
approved these changes
Mar 5, 2025
|
buildkite test this |
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Mar 5, 2025
(cherry picked from commit 2fa6651) # Conflicts: # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/amazonbedrock/AmazonBedrockServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/azureaistudio/AzureAiStudioServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/azureopenai/AzureOpenAiServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/cohere/CohereServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/openai/OpenAiServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/voyageai/VoyageAIServiceTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 5, 2025
(cherry picked from commit 2fa6651) # Conflicts: # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/amazonbedrock/AmazonBedrockServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/azureaistudio/AzureAiStudioServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/azureopenai/AzureOpenAiServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/cohere/CohereServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/openai/OpenAiServiceTests.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/voyageai/VoyageAIServiceTests.java
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
matchedTextfield from chunks. This is no longer required because we build the chunk text on demand using offsets. Removing this field should help with OOMs when chunking large documents.