Minor DocValuesDocReader cleanup #123619
Merged
Minor DocValuesDocReader cleanup #123619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instance members can be private, all final, and SearchLookup is unused.
javanna
added
>refactoring
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
cbuescher
approved these changes
Feb 27, 2025
| @Override | ||
| public LeafFieldComparator getLeafComparator(LeafReaderContext context) throws IOException { | ||
| return super.getLeafComparator(context); | ||
| } |
There was a problem hiding this comment.
Any reason to add this override that I might be missing?
There was a problem hiding this comment.
no, thanks for catching it, it was a leftover of some other experiment :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instance members can be private, all final, and SearchLookup is unused.