Report outcome of data node's shard snapshot master update #123652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ES-10991
DiannaHohensee
added
>enhancement
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DiannaHohensee
force-pushed
the
2025/02/27/ES-10991-status-description
branch
from
fdc0862 to
f482392
Compare
DiannaHohensee
commented
Feb 27, 2025
| localShard.getValue().getShardSnapshotResult(), | ||
| () -> null | ||
| (outcomeInfoString) -> localShard.getValue().updateStatusDescription( | ||
| Strings.format(""" |
There was a problem hiding this comment.
This could theoretically grow without bound -- appending the previous status string. I figure it's unlikely to happen, since we'd stop once a remote call successfully updates the cluster state. We'd have to keep rolling over the master, and keep failing to get majority, or persistence in the blob store for serverless.
There was a problem hiding this comment.
Yeah could we impose a limit here just in case? Simply truncating the string if it exceeds 1000 characters or something?
There was a problem hiding this comment.
Updated 👍 I used substring: a bit wordy, let me know if there's some other/better standard way of doing it.
DaveCTurner
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the information in the IndexShardSnapshotStatus's
statusDescription field to include the success/failure of the remote
call to the master node to update the shard snapshot state. This
allows us to see if there is a discrepancy between the state of the
data node and the master node.
Closes ES-10991