Add a faster path for single default project retrieving #123662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes single default project retrieving faster by using a single element map instead of a regular hash map.
ywangd
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
…ion-for-single-default
…ta.java Co-authored-by: Tim Vernum <[email protected]>
ywangd
added
the
auto-merge-without-approval
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Feb 28, 2025
We can avoid using the volatile field when there is only a single default project. Relates: elastic#123662
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Feb 28, 2025
No need to create new instances for the default project-id sent across the wire. We can use the singleton field which should speeds up key comparsion for Map.get operations. Relates: elastic#123662
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 5, 2025
No need to create new instances for the default project-id. We can use the singleton field which should speeds up key comparsion for Map.get operations. Relates: #123662
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
No need to create new instances for the default project-id. We can use the singleton field which should speeds up key comparsion for Map.get operations. Relates: elastic#123662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes single default project retrieving faster by using a single element map instead of a regular hash map.