-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Opster paginate changes rebase #123674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opster paginate changes rebase #123674
Conversation
Documentation preview: |
@georgewallace , if you could take a look at this and confirm that I did the PR to the correct place etc, that would be great. Should be good to go because previous PR was accepted, just not merged |
Pagination organizes search results into manageable pages, enhancing user interaction. Whether selecting specific page ranges or using infinite scroll, pagination offers a tailored user experience. | ||
|
||
The three commonly used pagination techniques are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pagination organizes search results into manageable pages, enhancing user interaction. Whether selecting specific page ranges or using infinite scroll, pagination offers a tailored user experience. | |
The three commonly used pagination techniques are: | |
{es} uses pagination to segment large result sets into manageable pages for efficient retrieval and processing. | |
{es} supports three pagination techniques: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original read a little marketing-y and direct voice is clearer :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree that maybe it sounds a bit marketing-y. However I think something that a lot of our documentation is missing is a helpful introduction to a topic. I.e. starting out telling the user exactly what the feature is used for and how it can help them rather than a technical overview
I think the rewrite optimizes clarity and concision and but it's not as helpful. Also elasticsearch doesn't use pagination, the engineer does.
This rewrite is trying to be less marketing-y:
"Pagination splits large search result sets into smaller pages, making them easier for users to navigate. You can implement it to let users jump to specific page ranges (e.g., 'Page 1, 2, 3') or use an infinite scroll method where more results load as the user scrolls.
{es} supports three pagination techniques:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree that maybe it sounds a bit marketing-y. However I think something that a lot of our documentation is missing is a helpful introduction to a topic.
I don't disagree but the original intro sentence wasn't helpful because it was long on verbiage and short on facts.
Pinging @elastic/es-docs (Team:Docs) |
….asciidoc Co-authored-by: Liam Thompson <[email protected]>
* This is a copy from the original ticket elastic#120171 * Update docs/reference/search/search-your-data/paginate-search-results.asciidoc Co-authored-by: Liam Thompson <[email protected]> --------- Co-authored-by: George Wallace <[email protected]> Co-authored-by: Liam Thompson <[email protected]>
* This is a copy from the original ticket #120171 * Update docs/reference/search/search-your-data/paginate-search-results.asciidoc --------- Co-authored-by: Kofi B <[email protected]> Co-authored-by: Liam Thompson <[email protected]>
* This is a copy from the original ticket #120171 * Update docs/reference/search/search-your-data/paginate-search-results.asciidoc --------- Co-authored-by: Kofi B <[email protected]> Co-authored-by: Liam Thompson <[email protected]>
Premigration changes made but didn't get merged in time. This is a dupe of #120171