Skip to content

Conversation

thekofimensah
Copy link
Contributor

@thekofimensah thekofimensah commented Feb 28, 2025

Premigration changes made but didn't get merged in time. This is a dupe of #120171

Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.17.4 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Feb 28, 2025
@thekofimensah
Copy link
Contributor Author

@georgewallace , if you could take a look at this and confirm that I did the PR to the correct place etc, that would be great. Should be good to go because previous PR was accepted, just not merged

@thekofimensah thekofimensah changed the title Opster kofi paginate changes rebase Opster paginate changes rebase Feb 28, 2025
Comment on lines 4 to 6
Pagination organizes search results into manageable pages, enhancing user interaction. Whether selecting specific page ranges or using infinite scroll, pagination offers a tailored user experience.

The three commonly used pagination techniques are:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pagination organizes search results into manageable pages, enhancing user interaction. Whether selecting specific page ranges or using infinite scroll, pagination offers a tailored user experience.
The three commonly used pagination techniques are:
{es} uses pagination to segment large result sets into manageable pages for efficient retrieval and processing.
{es} supports three pagination techniques:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original read a little marketing-y and direct voice is clearer :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree that maybe it sounds a bit marketing-y. However I think something that a lot of our documentation is missing is a helpful introduction to a topic. I.e. starting out telling the user exactly what the feature is used for and how it can help them rather than a technical overview

I think the rewrite optimizes clarity and concision and but it's not as helpful. Also elasticsearch doesn't use pagination, the engineer does.

This rewrite is trying to be less marketing-y:

"Pagination splits large search result sets into smaller pages, making them easier for users to navigate. You can implement it to let users jump to specific page ranges (e.g., 'Page 1, 2, 3') or use an infinite scroll method where more results load as the user scrolls.

{es} supports three pagination techniques:"

@leemthompo @georgewallace

Copy link
Contributor

@leemthompo leemthompo Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree that maybe it sounds a bit marketing-y. However I think something that a lot of our documentation is missing is a helpful introduction to a topic.

I don't disagree but the original intro sentence wasn't helpful because it was long on verbiage and short on facts.

@georgewallace georgewallace added >docs General docs changes Team:Docs Meta label for docs team labels Feb 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Feb 28, 2025
@georgewallace georgewallace self-assigned this Mar 1, 2025
@georgewallace georgewallace added auto-backport Automatically create backport pull requests when merged v8.18.0 v8.19.0 labels Mar 1, 2025
@georgewallace georgewallace merged commit 37230dc into elastic:8.17 Mar 1, 2025
7 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.18
8.x

georgewallace added a commit to georgewallace/elasticsearch that referenced this pull request Mar 1, 2025
* This is a copy from the original ticket elastic#120171

* Update docs/reference/search/search-your-data/paginate-search-results.asciidoc

Co-authored-by: Liam Thompson <[email protected]>

---------

Co-authored-by: George Wallace <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Mar 1, 2025
* This is a copy from the original ticket #120171

* Update docs/reference/search/search-your-data/paginate-search-results.asciidoc



---------

Co-authored-by: Kofi B <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Mar 1, 2025
* This is a copy from the original ticket #120171

* Update docs/reference/search/search-your-data/paginate-search-results.asciidoc



---------

Co-authored-by: Kofi B <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.17.4 v8.18.0 v8.19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants